splunk-connect-for-kubernetes icon indicating copy to clipboard operation
splunk-connect-for-kubernetes copied to clipboard

Published 20 hours ago • verified publisher icon splunk

Support setting gzip_compression flag for log forwarder

Open toscott opened this issue 2 years ago • 3 comments

Functionality depends on an upstream change

https://github.com/splunk/fluent-plugin-splunk-hec/pull/250

Proposed changes

Support potential new flag for gzip compression from: https://github.com/splunk/fluent-plugin-splunk-hec/pull/250

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • [x] I have read the CONTRIBUTING doc
  • [x] I have read the CLA
  • [x] I have added necessary documentation (if appropriate)

Hoping this PR might help with visibility on the upstream change.

  • [ ] Any dependent changes have been merged and published in downstream modules

toscott avatar Jul 28 '22 03:07 toscott

Can you also fix lint test failures?

hvaghani221 avatar Jul 29 '22 06:07 hvaghani221

I think gzip_compression should defaults to false

Fair. Will adjust

Can you also fix lint test failures?

Yup. Will push in a bit.

toscott avatar Aug 01 '22 00:08 toscott

I cannot merge it until splunk_hec plugin is released

hvaghani221 avatar Aug 01 '22 06:08 hvaghani221