security_content icon indicating copy to clipboard operation
security_content copied to clipboard

pytest failure

Open tccontre opened this issue 2 years ago • 1 comments

as requested by patrick, here is the issue for the pytest failure after submit detection PR for security content.

Screenshot 2022-08-31 at 11 09 53

https://github.com/splunk/security_content/runs/8132008116?check_suite_focus=true

tccontre avatar Sep 01 '22 10:09 tccontre

To provide a little more context, this is intended behavior at this time. In this example, the content failed validation due to an error in the yml (improperly calculated risk score). You can see this if you scroll back in the logs some more: image Having said that, it probably makes more sense to not have this function do a sys.exit(1) when it encounters an error. This function should either raise an exception that is caught by the caller or return a list of error(s) that can be caught by the caller and handled appropriately. I will refactor this today and link the PR with the updates for review.

pyth0n1c avatar Sep 01 '22 14:09 pyth0n1c