wordpress-comment-blacklist icon indicating copy to clipboard operation
wordpress-comment-blacklist copied to clipboard

Update terminology to match current WordPress usage

Open Zodiac1978 opened this issue 5 years ago • 7 comments

Just a heads up: With the coming WordPress 5.5 the blacklist_keys are changed to blocklist_keys.

See this changeset: https://core.trac.wordpress.org/changeset/48121

For all the people maintaining plugins to update those keys with the list.

Zodiac1978 avatar Jul 11 '20 19:07 Zodiac1978

Thanks, @Zodiac1978 … I was just reading up on this change.

Along with plugins that access the keys, it will require changing the name of this project, the name of the repo itself, and updating the associated documentation.

It looks like I’ll be able to rename the repo and have the old URL redirect automatically.

https://docs.github.com/en/github/administering-a-repository/renaming-a-repository

splorp avatar Jul 12 '20 03:07 splorp

The name of the option has changed in the final version of WordPress 5.5 to disallowed_keys https://make.wordpress.org/core/2020/07/23/codebase-language-improvements-in-5-5/

Zodiac1978 avatar Jul 23 '20 08:07 Zodiac1978

Thanks for the update.

splorp avatar Jul 23 '20 17:07 splorp

Related to this, the user interface terminology on the Discussion Settings page has changed as well.

The Comment Blacklist section has been changed to Disallowed Comment Keys

This really futzes up the name of this repository.

splorp avatar Jul 31 '20 21:07 splorp

So, here are my thoughts …

WordPress 5.3 and earlier use Comment Blacklist WordPress 5.4 changed Comment Blacklist to Comment Blocklist WordPress 5.5 changed Comment Blocklist to Disallowed Comment Keys

All of these variations need to be referenced in the documentation, as you never know what version of WP is being used.

While “Disallowed Comment Keys” does make some semantic sense, it feels like a programmer decided to make the change to he text without consulting a copywriter first. (Which in reality, is probably what happened.)

“Disallowed Comment Keys” is an incredibly awkward phrase compared to something as straightforward as “Blocklist”. Likewise, changing the repository name to something that matches the interface terminology (eg: “Disallowed Comment Keys List for WordPress”) would be just just silly.

Changing “blacklist” to “blocklist” in both the repository name and URL will be in smoothest transition, while still maintaining any necessary documentation updates to address the other changes implemented in the WP interface.

splorp avatar Sep 06 '20 17:09 splorp

Addressed the Discussion Settings information in the read me to reflect the various field name iterations in commit de3e332

splorp avatar Jan 08 '23 17:01 splorp

Started changing “blacklist” to “blocklist” in the documentation per commit 9c265533d72c216eeb199fd493cb1db9ae0706db

Still need to research what will happen regarding direct links to the blacklist.txt file if the repo name and file name change.

splorp avatar Feb 06 '23 22:02 splorp