dokuwiki-plugin-sync
dokuwiki-plugin-sync copied to clipboard
splitbrain
PHP 8.1 - Warnings on Admin pages
Warning: Undefined array key "no" in .../dokuwiki/lib/plugins/sync/admin.php on line 20
Occurs with PHP 8.1 / DokuWiki Igor when accessing the Admin page (http://path.to/dokuwiki/doku.php?id=index&do=admin)
Also on http://path.to/dokuwiki/doku.php?id=index&do=admin&page=sync
Warning: Undefined array key "sync_pages" in .../dokuwiki/lib/plugins/sync/admin.php on line 110
Warning: Undefined array key "sync_media" in .../dokuwiki/lib/plugins/sync/admin.php on line 110
Warning: Undefined array key "startsync" in .../dokuwiki/lib/plugins/sync/admin.php on line 145
The next 2 warnings occur on lines 284, 288, 300, 303, 311, 314, 317
Warning: Undefined array key "" in .../dokuwiki/lib/plugins/sync/admin.php
Warning: Trying to access array offset on value of type null in .../dokuwiki/lib/plugins/sync/admin.php
@splitbrain considering your recent note in @gturri's PR (https://github.com/splitbrain/dokuwiki-plugin-sync/pull/65#issuecomment-1685891496)
this is all moot considering that this plugin needs more cleanup anyway and that I had started the cleanup a long while ago in the refactor branch. Unfortunately I got distracted and never finished it...
When you say this is all moot, does this mean that you would not be accepting further PRs patching this issue (or other quick / compatibility fixes), due to the pending refactor ?
If not, are you planning to resume the refactoring effort at some point ? Or should this plugin be considered dead / unsupported ?
I would accept pull requests on top of the refactor branch. I plan on resume working on it in the future. But the future may be years ahead. Alternatively you can always hire me via CosmoCode...
OK, fair enough.
Alternatively you can always hire me via CosmoCode...
Sadly the poor non-profit organizations I use this plugin for most likely can't afford your rates 🤑
Code contributions is really the best I could offer. Do you reckon the refactor branch is in a more-or-less usable state ? If so I could consider beta-testing it and providing patches.
Do you reckon the refactor branch is in a more-or-less usable state
I really do not remember. The biggest change was that instead of passing each file as a single POST variable JSON is exchanged with the backend to avoid running into limits with too many variables when a lot has changed. Or at least that was the plan. I really don't remember how far I came...