dokuwiki-plugin-data
dokuwiki-plugin-data copied to clipboard
splitbrain
Added the ability to rebuild the intire database from the admin area
What happened to helper.php? The whole file is changed? Did you change line endings or something?
Why the code in action.php? This should be part of the admin component's handle() method.
Can you please fix these two things?
Hi, thanks for the feedback, very valid points.
Although I haven’t noticed the change in line-endings, I always struggle with cross platform collaboration. I’ll login to my linux box and fix it on there.
I found your guidelines for writing admin plugins, so this would probably be the time that I confess that I should have RTFM :)
I’ll revert the commit, fix the changes and re-submit
Cheers,
Stephan
From: Andreas Gohr [mailto:[email protected]] Sent: Friday, 7 June 2013 6:55 PM To: splitbrain/dokuwiki-plugin-data Cc: SparklingSoftware Subject: Re: [dokuwiki-plugin-data] Added the ability to rebuild the intire database from the admin area (#82)
What happened to helper.php? The whole file is changed? Did you change line endings or something?
Why the code in action.php? This should be part of the admin component's handle() method.
Can you please fix these two things?
— Reply to this email directly or view it on GitHub https://github.com/splitbrain/dokuwiki-plugin-data/pull/82#issuecomment-19095885 . https://github.com/notifications/beacon/uM_aGQZa3AxgnkFZKG8q2Qad4I7tEbZeRuS5QfRnkeMrRcA4Fpr3Qk1LXVHApIg1.gif
Hi,
thanks for the rebuild functionality! We lost our database the other day and had to restore from a backup which missed the latest entries. Rebuilding added them back.
I had to fix an issue with page titles, though, and addressed the points by splitbrain at the same time. Do I have to fork the plugin to provide a patch or is there another way?
Andreas
Hi Andreas,
Sorry for the late reply.
Yeah, I has the same issue. We do continuous deployment for our content, so we actually blow away all our data on a daily basis :)
It’s been a while but I remember sending a pull request ages ago and did mean to follow up on the review comments before resubmitting.
There are basically two approaches and depending on your technical skills, you can pick either of the two:
-
Create a fork of my code, implement the changes there and send me pull request, which I’m happy to accept obviously :) This way you get credit for your code but you need some git knowledge. -
Email me the code, I’ll copy paste it in and submit the pull request to the central data-plugin repo. No git knowledge required, but no credit in the git history (I imagine you’ll be mentioned as the contributor on the wiki and in the code page headers)
Whatever you think is the best for you.
I’m happy to commit to follow up on this sooner than responding to this email. :)
Thanks for contributing!
Stephan
From: andyboeh [mailto:[email protected]] Sent: Tuesday, 29 April 2014 7:14 PM To: splitbrain/dokuwiki-plugin-data Cc: SparklingSoftware Subject: Re: [dokuwiki-plugin-data] Added the ability to rebuild the intire database from the admin area (#82)
Hi,
thanks for the rebuild functionality! We lost our database the other day and had to restore from a backup which missed the latest entries. Rebuilding added them back.
I had to fix an issue with page titles, though, and addressed the points by splitbrain at the same time. Do I have to fork the plugin to provide a patch or is there another way?
Andreas
— Reply to this email directly or view it on GitHub https://github.com/splitbrain/dokuwiki-plugin-data/pull/82#issuecomment-41655668 . https://github.com/notifications/beacon/1478157__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxNDM4MjAxOCwiZGF0YSI6eyJpZCI6MTE2NTU5MzN9fQ==--cc3966de62c5b840ae951c7ce78ab1c73050c24c.gif
Does this have any advantage over the more general https://www.dokuwiki.org/plugin:searchindex? See also #27: Is it faster to rebuild data's database than DokuWiki's (search-) index? Both have to check all pages, or do I miss something? Note: a great feature for both ways were the ability to constrain rebuilding on a certain namespace (some namespaces may be of more interest for up-to-date indexes / databases than others), maybe (also) the other way round by excluding certain namespaces - for some namespaces "access by linking" does the job, while for others "access by searching / data plugin" is more important, and rebuilding only for the latter could be done much faster than rebuilding for all.
