py_trees icon indicating copy to clipboard operation
py_trees copied to clipboard

Retry decorator returning SUCCESS when child is INVALID

Open CleanBandit5595 opened this issue 1 year ago • 1 comments

https://github.com/splintered-reality/py_trees/blob/0d5b39f2f6333c504406d8a63052c456c6bd1ce5/py_trees/decorators.py#L281

        else:  # SUCCESS
            self.feedback_message = (
                f"succeeded [status: {self.failures} failure from {self.num_failures}]"
            )
            return common.Status.SUCCESS

This causes the Retry decorator to return SUCCESS when the child's status is INVALID.

Which I believe isn't a wanted functionality, but the problem did arise from my fault, when a behaviour I wrote returning INVALID accidentally. This was, however, hard to debug, since the decorator simply returns success...

CleanBandit5595 avatar Jan 05 '24 11:01 CleanBandit5595