get5 icon indicating copy to clipboard operation
get5 copied to clipboard

Backups from last round in map don't work

Open nickdnk opened this issue 2 years ago • 0 comments

I don't understand why this is happening:

https://github.com/splewis/get5/blob/e35eb6bddaa7ad990a3dcf70091eb7fba4d8cdc7/scripting/get5.sp#L1152-L1155

It seems the backup written here never serves any purpose. If you want to restore to the last round of the match, we should use the backup written at the start of that round. If we want to restore to the next map's prelive, there's also a separate file for that.

Should this call not just be removed? I don't understand it.

Edit: After some trial-and-error, this seems to totally break last-round backups. If you play 14:16, the last round backup (round_29) will be overwritten with score 14:16, instead of, say, 14:15, causing the game to immediately end if you were to reload that backup.

nickdnk avatar Aug 08 '22 20:08 nickdnk