get5 icon indicating copy to clipboard operation
get5 copied to clipboard

Ensure correct MapNumber logic when restoring from backups with draws + add series clinch config parameter

Open nickdnk opened this issue 2 years ago • 2 comments

This should fix https://github.com/splewis/get5/issues/817.

I also adjusted Get5_OnBackupRestore to have the correct map and round number, indicating the match, map and round being restored to.

Tried to reduce use of Get5_GetMapNumber() where it is not needed.

~~Totally untested at the moment~~ Edit: Tested, but https://github.com/splewis/get5/issues/822 needs to be fixed, otherwise last-round backups in a map don't work. Edit 2: I put the fix for that in this PR.

nickdnk avatar Aug 07 '22 20:08 nickdnk

Last commit fixes https://github.com/splewis/get5/issues/728

nickdnk avatar Aug 09 '22 18:08 nickdnk

Tested everything in here and it seems to work as expected. Tested clinch_series and also tested that bo2 still works as expected.

nickdnk avatar Aug 09 '22 23:08 nickdnk

Now also fixes https://github.com/splewis/get5/issues/213

nickdnk avatar Aug 10 '22 23:08 nickdnk

Fixes https://github.com/splewis/get5/issues/190 now also.

nickdnk avatar Aug 12 '22 13:08 nickdnk

I changed the translation logic to always inject the color around variables if applicable. This means we don't have to make sure different languages use the same colors. I also cleaned up some of the translations a bit, where I could.

Player names are now colored based on the side they are on, so for instance when PlayerName has requested a tactical pause. is printed, PlayerName will now be either yellow or blue, depending on the side the player is on.

Commands in translations (.ie. type !unpause to continue) are now always colored green and have been changed to be injected variables as well.

nickdnk avatar Aug 12 '22 21:08 nickdnk