Hostname not being restored after match finish

[mrc4tt]

Hi,

It could be nice to get little function on get5 plugin, with a little change after the match is finished, so "hostname" aka servername will be changed back as normal from "server.cfg"

Example: Match1 > Hostname: Get5: Mikkel vs Test1 After 16-0 - where the match is finished. Server is still having "Get5: Mikkel vs Test1" as servername. The server should have changed the server name to what it has from server.cfg: Example:

1. Get5: Mikkel vs Test1 (Match)
2. Mikkel's Server (After Match is finished) - exec from the server.cfg (from get5 plugin)

[splewis]

Are you sure that's not already happening? get5 has some code already that saves previous cvar values before execution & restores them later, but things get a bit confusing since there's both the warmup & live config.

Can you make sure to check the actual hostname cvar in console? The display on the scoreboard isn't an accurate reflection of the cvar, the last time I checked (it only seemed to update on map loads).

[mrc4tt]

It doesn't change the hostname of Get5: Mikkel vs Test1 to Mikkel's Server (from server.cfg) after the match is finished. which it doesn't do.

Aka:

  g_SetHostnameCvar = CreateConVar(
      "get5_hostname_format", "Get5: {TEAM1} vs {TEAM2}",

After MATCH is done with 16-0 - It's still running with Get5: Test1 vs Test2 - My question is: Isn't it supposed to change the server name back as it was called when the game is over, or what?

Example: Game1: Hostname will be: Get5: spelwis vs mikkel Game1 is finish 16-0 to spelwis - Here is the problem, It don't exec server.cfg OR change hostname back as it was before match was started!

[splewis]

After MATCH is done with 16-0 - It's still running with Get5: Test1 vs Test2

I understand that. I'm asking how you're determining what "it" is. Are you:

1. Looking at the scoreboard in-game
2. Checking the value of the cvar via console (like sm_cvar hostname or such)

If you think there is indeed a bug, you should post steps to reproduce as well.

[mrc4tt]

Checking the value of the cvar via console (like sm_cvar hostname or such) & checking the server on favorites (via Steam)

[DennisF10]

I can confirm that the hostname doesn't change back, checked server browser, scoreboard and sm_cvar hostname.

[ndstudios-admin]

Yes, I can agree. I have the same issue with backups.

[Drarig29]

@MikkelDK is that fixed? Why did you close it?

[mrc4tt]

@Drarig29 No.

I did close it because it will not be made/fix (since I have waited). And I'm not an SM coder, so I can't make PR. It does not change "hostname" back to the default hostname (after the game is finish).

[Drarig29]

Okay, then it's a real bug. I think this should be reopened and marked with the 'bug' label. Maybe it needed a little bump.

It's just quite hard to debug it, maybe it's a timing issue. Just need someone to investigate.

@splewis what do you think?