get5-web icon indicating copy to clipboard operation
get5-web copied to clipboard

Fix charset

Open prank150 opened this issue 6 years ago • 3 comments

Hi. I'm japanese csgo player.

Fix charset in match config file.

I noticed in gaming team name is not ascii and confirmed match config is not utf-8 encoding.

This request is that. You maybe have better way.

prank150 avatar Jul 07 '19 07:07 prank150

I don't know the implications of this still, but at a glance it looks like it could just be specified in the config file rather than forced this way in __init__.py.

splewis avatar Jul 07 '19 21:07 splewis

It's just as you said !

I should have fixed prod_config.py. (´;ω;`)

JSON_AS_ASCII = False

But recommended to default this, because for non-ASCII character countries !

Thank you for your response.

prank150 avatar Jul 08 '19 10:07 prank150

But recommended to default this, because for non-ASCII character countries !

I agree, but this PR is still forcing the configuration option. I'll merge this if it changes the default configuration file.

splewis avatar Nov 03 '19 18:11 splewis