rstats icon indicating copy to clipboard operation
rstats copied to clipboard

three plugin has arbitrary 'faces' warning at 1,000

Open air opened this issue 11 years ago • 2 comments

I wondered why the three plugin has this line

https://github.com/spite/rstats/blob/master/src/rStats.extras.js#L101

Forcing a warning when your faces gets above 1,000. This must be arbitrary given you don't know how complex a scene the user will have - mine has many more. I couldn't create the right incantation to override the value without patching the js.

Any thoughts? Thanks.

air avatar May 12 '14 22:05 air

Yes, absolutely. It's a very arbitrary value, it was an example of how it would work. The actual value should be several orders of magnitude higher (or none).

The only way right now is to patch the WebGL plugin. I haven't thought of a way of instantiating a plugin and passing values to the values defines. May be another JSON object that is used to override the default values would be useful?

spite avatar May 12 '14 22:05 spite

Perhaps an easy way would be to have two optional arguments that allow _values and _groups to be overridden. The current values would be defaults for users that don't pass them in?

air avatar May 15 '14 17:05 air