THREE.MeshLine
THREE.MeshLine copied to clipboard
Maintainers
Where are the maintainers on this project?
There are several outstanding merge requests that need to go into the next release.
Specifically the fix in the vertex shader and typescript support
https://github.com/utsuboco/THREE.MeshLine I made a new version of a library using vite and typescript.
Temporary I published it on npm under the name meshline. It should work the same way, and it now exports es(2.89kb brotli), umd(3.13kb) and has the ts definitions.
see https://github.com/spite/THREE.MeshLine/issues/139#issuecomment-842851031
Demo: https://codesandbox.io/s/confetti-typescript-meshline-0f4mi?file=/src/index.tsx
I guess the author might want to deprecate this project. I sent links to him on Twitter twice, both ignored. while he is definitely active on Twitter and on GitHub. Just sad he didn't assign another maintainer for this project.
There is another maintainer. @jiyinyiyong do you want to be a maintainer?
I would propose moving this library to https://github.com/pmndrs @RenaudRohlinger is a member but the point of it is that critical libraries can be maintained as a collective. We have helped multiple libs already that otherwise would have been abandoned like https://github.com/pmndrs/cannon-es or https://github.com/pmndrs/detect-gpu
The author remains, it's still yours @spite but we take liberty in maintaining, inviting more devs to join as well as keeping it up to date with tooling, types and so on. this way something so useful like meshline doesn't outdate as long as people are relying on it and have a vested interest in keeping it alive.
@spite can we move it to https://github.com/pmndrs?
~~@spite I have some time now. guess I could help migrating this lib to ES Modules.~~
forked my own version of the package... https://github.com/Quatrefoil-GL/meshline .
any updates on this?
https://github.com/utsuboco/THREE.MeshLine I made a new version of a library using vite and typescript.
Temporary I published it on npm under the name meshline. It should work the same way, and it now exports es(2.89kb brotli), umd(3.13kb) and has the ts definitions.
see #139 (comment)
Demo: https://codesandbox.io/s/confetti-typescript-meshline-0f4mi?file=/src/index.tsx
For those that come later, after trying many forks/permutations to get MeshLine working with the latest three/react-three-fiber/drei stack (at time of writing) and typescript, @RenaudRohlinger version worked for me.
Note that there are some critical changes from the original r3f Fatline demo code, base your code off the example given in the quoted reply and/or the forked repo README--NOT off the original r3f demo! (I burned an hour to a bug caused by not noticing this.) In particular, vertices
is switched for points
.
The components will give TS errors about not being on JSX.IntrinsicElements
. To fix and make full use of the awesome TS support in this fork, this worked for me:
import {
extend, ReactThreeFiber,
} from '@react-three/fiber';
import { MeshLine, MeshLineMaterial, MeshLineRaycast } from 'meshline';
extend({ MeshLine, MeshLineMaterial });
/* eslint-disable no-unused-vars */
declare global {
namespace JSX {
interface IntrinsicElements {
'meshLine': ReactThreeFiber.Object3DNode<MeshLine, typeof MeshLine>;
'meshLineMaterial': ReactThreeFiber.Object3DNode<MeshLineMaterial, typeof MeshLineMaterial>;
}
}
}
/* eslint-enable no-unused-vars */
Which owes credit to: https://github.com/pmndrs/react-three-fiber/issues/130#issuecomment-604502461
HUGE THANK YOU TO THIS LIB AND TO RenaudRohlinger. Happy lining!
@spite @bryantcodesart @robksawyer
@RenaudRohlinger has agreed to move it over to pmndrs https://github.com/pmndrs/THREE.MeshLine this way more devs will be able to maintain and merge prs.
i've opted to make some slight breaking changes and release a major: https://github.com/pmndrs/THREE.MeshLine/pull/4
examples are still open, it seems the demos that were in the repo don't work any longer https://github.com/spite/THREE.MeshLine/issues/154 if i find time i can try to fix them up.
Awesome! Thanks for following up.
Is it intentional that the pmndrs repo has issues disabled?