LumiLights icon indicating copy to clipboard operation
LumiLights copied to clipboard

Some options doesn't exist

Open wstar2022 opened this issue 2 years ago • 4 comments

There is a key "config.lumi_lights.value.reflection_oversampling" in the language file en_us.json. But when I try to look for the option in other files, there's no such option.

Search result is in the picture below.

result

wstar2022 avatar Aug 29 '22 02:08 wstar2022

It's entirely possible that it's just an unused feature

ambrosia13 avatar Aug 29 '22 02:08 ambrosia13

I guess so.

wstar2022 avatar Aug 29 '22 02:08 wstar2022

I found another option that doesn't exist, named "config.lumi_lights.value.lightrays_mode".

Search result is in the picture below.

result

wstar2022 avatar Aug 29 '22 03:08 wstar2022

Lumi Lights gains and loses features all the time so this is to be expected.

Specifically, when a new feature is added there will be a few options that come with it, but as the feature is refined I sometimes replaced options with magic constants.

I don't feel the need to remove these because they aren't causing any issues, and honestly I forgot most of them exist. I can remove them if you want though, don't think there is any need to keep them.

spiralhalo avatar Aug 31 '22 06:08 spiralhalo

Okay, I got it. I hope that these missing options will be added one by one in the future. :)

#76

wstar2022 avatar Jan 29 '23 03:01 wstar2022