vortex icon indicating copy to clipboard operation
vortex copied to clipboard

LayoutWriter doesn't respect validity of the top level Struct array

Open robert3005 opened this issue 1 year ago • 3 comments

Right now if StructArray has top level validity that's not AllValid or NonNullable the validity is discarded

robert3005 avatar Sep 03 '24 18:09 robert3005

Could you please provide more details? I'm interested in this issue and would like to attempt to resolve it.

doki23 avatar Oct 07 '24 02:10 doki23

This is likely not a good first issue. The solution here is likely to either forbid writing top level structs with validity other than nonnullable and provide a function to push validity of the struct to the children, i.e. run a filter. Alternatively we need to teach column layout about one extra validity array which shouldn't be bad but likely unnecessary

robert3005 avatar Oct 15 '24 07:10 robert3005

In the current format, isn't it true that this is actually any struct array? I'd like to at least known the fix here to make sure it's not a breaking change when we do.

gatesn avatar Apr 14 '25 07:04 gatesn

We should assert at write-time that struct arrays have Validity::NonNullable or Validity::AllValid

gatesn avatar May 29 '25 07:05 gatesn