vortex icon indicating copy to clipboard operation
vortex copied to clipboard

BitView SIMD filtering

Open gatesn opened this issue 1 month ago • 3 comments

gatesn avatar Nov 16 '25 15:11 gatesn

CodSpeed Performance Report

Merging #5356 will degrade performances by 14.99%

Comparing ngates/bitview-filter (a783a69) with develop (35d12a3)

Summary

❌ 15 regressions
✅ 1395 untouched
🆕 157 new
⏩ 631 skipped[^skipped]
🗄️ 28 archived benchmarks run[^archived]

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
take_indices[(1000, 16, 0.005)] 20.8 µs 24.4 µs -14.95%
take_indices[(1000, 16, 0.01)] 20.9 µs 24.6 µs -14.97%
take_indices[(1000, 16, 0.03)] 22.8 µs 26.4 µs -13.62%
take_indices[(1000, 256, 0.005)] 20.5 µs 24.2 µs -14.99%
take_indices[(1000, 256, 0.01)] 20.7 µs 24.4 µs -14.97%
take_indices[(1000, 256, 0.03)] 21.1 µs 24.8 µs -14.84%
take_indices[(1000, 4, 0.005)] 23.3 µs 26.9 µs -13.29%
take_indices[(1000, 4, 0.01)] 22.1 µs 25.7 µs -14.01%
take_indices[(1000, 4, 0.03)] 25.1 µs 28.7 µs -12.55%
take_indices[(10000, 16, 0.005)] 24.4 µs 28 µs -12.85%
take_indices[(10000, 16, 0.01)] 27.3 µs 30.9 µs -11.66%
take_indices[(10000, 256, 0.005)] 22.7 µs 26.4 µs -13.94%
take_indices[(10000, 256, 0.01)] 24.8 µs 28.4 µs -12.84%
take_indices[(10000, 4, 0.005)] 27 µs 30.6 µs -11.77%
take_indices[(10000, 4, 0.01)] 30.8 µs 34.4 µs -10.48%
🆕 filter_u128[ActualFilter, 0.01] N/A 823.3 ns N/A
🆕 filter_u128[ActualFilter, 0.05] N/A 865.8 ns N/A
🆕 filter_u128[ActualFilter, 0.1] N/A 880.8 ns N/A
🆕 filter_u128[ActualFilter, 0.25] N/A 1 µs N/A
🆕 filter_u128[ActualFilter, 0.5] N/A 1.2 µs N/A
... ... ... ... ...

:information_source: Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks. [^skipped]: 631 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. [^archived]: 28 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

codspeed-hq[bot] avatar Nov 18 '25 14:11 codspeed-hq[bot]

Codecov Report

:x: Patch coverage is 0% with 43 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 85.89%. Comparing base (1aac9ca) to head (492dffd). :warning: Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-compute/src/filter/slice/scalar.rs 0.00% 36 Missing :warning:
vortex-buffer/src/bit/view.rs 0.00% 4 Missing :warning:
vortex-compute/src/filter/slice/mod.rs 0.00% 3 Missing :warning:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 18 '25 14:11 codecov[bot]

actually I think this deserves some cleaning up / monomorphizing before we merge this (I will make the scalar implementation better on my PR https://github.com/vortex-data/vortex/pull/5399)

connortsui20 avatar Nov 19 '25 19:11 connortsui20