spiraldb
support DynamicFilterPhysicalExpr
Codecov Report
:x: Patch coverage is 95.00000% with 6 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 88.03%. Comparing base (839b7dd) to head (a9e0abb).
:warning: Report is 91 commits behind head on develop.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| vortex-datafusion/src/persistent/mod.rs | 92.77% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
We cannot currently run pre commit benchmark on fork so I created this (https://github.com/vortex-data/vortex/pull/4986)
I can belive some of the perf impact, but I suspect AWS tonight is just extremely noisy, gotta love the 40% on clickbecnh q0.
I can belive some of the perf impact, but I suspect AWS tonight is just extremely noisy, gotta love the 40% on clickbecnh q0.
Is there a benchmark or something I'm not seeing? If it's Polar Signal I don't seem to have access.
They ran on this PR, seems like there's an issue to trigger benchmarks on this branch (@joseph-isaacs got something I can look at? Would love to be able to do that)
@AdamGS what's your read on the state of this PR / what can I do to help? It's not clear to me if there are issues with benchmarks, if @joseph-isaacs is planning on taking it over in another PR, if I should rewrite the commits with the licensing info, etc.
You beat me to comment by a minute! I've re-triggered the benchmarks over at https://github.com/vortex-data/vortex/pull/4986, if you can it'll be great if you can fix the lint failure (just run with nightly) and the DCO thing and we can merge this IMO.
Last benchmarks run - https://github.com/vortex-data/vortex/actions/runs/18684856431