vortex icon indicating copy to clipboard operation
vortex copied to clipboard

Remove vortex-ffi

Open gatesn opened this issue 3 months ago • 5 comments

This was an attempt at building a C API for Vortex. We can revive this later if we want, but the current API is not at all stable or designed for forward compatibility, including exposing public struct fields etc.

In practice, our language bindings either use some Rust framework (cxx, pyo3), or use a statically linked C API that therefore does not care about compatibility and evolves in lock-step with the bindings.

gatesn avatar Sep 16 '25 10:09 gatesn

Surprised that we don't really use this anywhere. If we don't have any users that rely on vortex-ffi, sgtm.

0ax1 avatar Sep 16 '25 10:09 0ax1

Seems this would only get the effort it needs if we forced ourselves to go through that api layer. Right now it's simpler to use binding generators so we might as well delete it.

robert3005 avatar Sep 16 '25 12:09 robert3005

+1, nuke it

lwwmanning avatar Sep 16 '25 16:09 lwwmanning

Just noting that we'll need to resurrect this if we ever want Golang or NodeJS bindings, but neither of those exist or are being demanded rn anyway.

a10y avatar Oct 20 '25 18:10 a10y

I think we'd end up using the Rust-specific libraries for binding to those languages, same as Py03. e.g. https://github.com/neon-bindings/neon

gatesn avatar Oct 20 '25 20:10 gatesn