vortex icon indicating copy to clipboard operation
vortex copied to clipboard

Implement CompareFn for ByteBoolEncoding by comparing &[bool]

Open gatesn opened this issue 1 year ago • 1 comments

gatesn avatar Nov 21 '24 09:11 gatesn

Hi, please provide more information about this issue, and I can help implement it.

Have searched in the codebase, there is no ByteBool, only ByteBoolArray in encodings/bytebool/src/array.rs

klion26 avatar Mar 27 '25 07:03 klion26

@klion26 apologies for the delay

The task is about this compute function:

https://github.com/vortex-data/vortex/blob/d88fc23459c362f3ebce4a274169538fcb6698a8/vortex-array/src/compute/compare.rs#L123-L130

Roughly, the way it works is that by checking different CompareKernel - if some of them produces the result, that'd be the output of that function

That's the example of CompareKernel implementation: https://github.com/vortex-data/vortex/blob/d88fc23459c362f3ebce4a274169538fcb6698a8/vortex-array/src/arrays/varbin/compute/compare.rs#L20

You can notice that this kernel is implemented by many arrays but not for boolean array (there is no impl CompareKernel for BoolVTable). The task is to implement that 🙂

blaginin avatar Jul 28 '25 15:07 blaginin