framework icon indicating copy to clipboard operation
framework copied to clipboard

Published 20 hours ago • verified publisher icon spiral

Do not require the aws-sdk composer package if the user wants to work with the async-aws package

Open roquie opened this issue 2 years ago • 0 comments

Description

It conflicts with suggest:

https://github.com/spiral/framework/blob/1a8851523ad1eb62bcbb50be7eff47646c711692/src/Storage/composer.json#L49

How To Reproduce

  1. install async-aws package
  2. try to use it without aws-sdk

Additional Info

Q A
Framework Version ^2.8
PHP version 8.1
Operating system MacOS Latest

Possible fix

Add a !$async check to https://github.com/spiral/framework/blob/1a8851523ad1eb62bcbb50be7eff47646c711692/src/Framework/Bootloader/Storage/StorageConfig.php#L187

roquie avatar Dec 02 '21 17:12 roquie