daybed icon indicating copy to clipboard operation
daybed copied to clipboard

Improve the ElasticSearch cluster configuration to allow basic_auth ES access

Open Natim opened this issue 11 years ago • 9 comments
trafficstars

Natim avatar Nov 12 '14 16:11 Natim

Updated.

Natim avatar Nov 12 '14 16:11 Natim

I'm not against merging this, but a bit doubtful though.

We can have all this code in Daybed, but in the mean time, opening a PR on elasticsearch-py would be worth it IHMO. I don't see why it shouldn't support absolute urls for hosts!

leplatrem avatar Nov 12 '14 22:11 leplatrem

Why should it?

Natim avatar Nov 12 '14 22:11 Natim

The dict formalism is rather curious, since there's a standard for that! RFC-1738 :)

leplatrem avatar Nov 12 '14 23:11 leplatrem

I can make a pull-request to them based on this assumption. There is not urgency yet to merge this patch since I already applied it in production.

Natim avatar Nov 13 '14 09:11 Natim

Ok.

Also, I wouldn't have created a dedicated module just for one utility function. But it may be a matter of taste :) More generally, we should start thinking of #213 :)

leplatrem avatar Nov 13 '14 09:11 leplatrem

More generally, we should start thinking of #213 :)

Exactly the reason why I did it like so :)

Natim avatar Nov 13 '14 09:11 Natim

Here we go: https://github.com/elasticsearch/elasticsearch-py/pull/149

Natim avatar Nov 13 '14 10:11 Natim

Good job @Natim! Your PR was merged in ES python client :) We will soon be able to close this here!

leplatrem avatar Nov 14 '14 15:11 leplatrem