roer icon indicating copy to clipboard operation
roer copied to clipboard

Published 20 hours ago • verified publisher icon spinnaker

Failed pipeline plan should have a return code of 1

Open nextrevision opened this issue 7 years ago • 1 comments

Whenever a pipeline-template plan fails due to an invalid template the return code is still 0 (see https://github.com/spinnaker/roer/blob/master/actions.go#L234). This makes testing templates in a CI system much harder.

Would be great if we could have a RC of 1

nextrevision avatar Dec 01 '17 18:12 nextrevision

If I'm not mistaken, this was fix up by #29.

benjaminws avatar Mar 14 '18 14:03 benjaminws