orca
orca copied to clipboard
feat(pipeline executions/orca): attribue to explicitly skip the outputs section in Deployment Manifest or Run Job stage
Most K8S deployments do not use the outputs in downstream stages. So, if it is not used
users can skip the output of the Deployment Manifest and Run Job (Manifest) stage by
specifiying the attribute noOutput
set to false in the stage json.
This significantly reduces the execution context being saved in redis/databse or sent to the browser.r.
This attempts to address the issues mentioned in https://github.com/spinnaker/spinnaker/issues/6159 https://github.com/spinnaker/spinnaker/issues/6159
The issue is compounded when there is a nesting of pipelines and the manifests are duplicated many times over in the execution context. There is one PR (https://github.com/spinnaker/orca/pull/3989) that also attempts to address the issue. It tries to do it at the pipeline stage. This PR attempts to apply the same fix but in a much more narrower scope - in Deploy Manifest and Run Job (Manifest) stages. One advantage of this is that it not only reduces the payload of the pipeline stages, but also of Deploy Manifest and Run Job stages. Hence overall it further reduces the data saved in redis/database as well as the amount of data transferred to the browser.
The following commits need their title changed:
-
d33c26a0e0ac180b504f2bd8c4274ac62b9f8190: Most K8S deployments do not use the outputs in downstream stages. So, if it is not used
-
2328eaf5f0932a2408cbbb5ce5418ccece28040b:
attribue to skip the outputs section in Deployment Manifest or Run Job stage
Please format your commit title into the form:
<type>(<scope>): <subject>
, e.g. fix(kubernetes): address NPE in status check
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.
I forked your fix to my own repo to fix the PR Status Checks https://github.com/spinnaker/orca/pull/4242