kork icon indicating copy to clipboard operation
kork copied to clipboard

Add Observability Plugin as part of kork-actuator

Open danielGz opened this issue 1 year ago • 2 comments

This work is about donating the armory observability plugin: https://blog.spinnaker.io/announcing-the-new-spinnaker-observability-plugin-d7fbb17e1e07 as part of kork-actuator

This is a sample configuration

observability:
  enabled: true
  config:
    metrics:
      prometheus:
        enabled: true
management:
  metrics:
    export:
      datadog:
        enabled: false
  endpoints:
    web:
      exposure:
        include: health,info,aop-prometheus

danielGz avatar Feb 14 '25 16:02 danielGz

The following commits need their title changed:

  • 91603ddd4711b641d529806904b4f72d99b33750: fixes for observability to be autonomous

  • 4db2425333dbf0b65886b32b18c89ae75746054e: modifications for observability functionality autonomy

  • 8910407f0a5a0984e0e6df4527302f7cf0d2df1d: removed unnecessary file

  • 8a34d3ad2a627b710808edaa7329bf7979508812: added tests

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

spinnakerbot avatar Feb 15 '25 00:02 spinnakerbot

Thanks so much for getting started on this work. I'd like to wait until we release 1.37.0 though so we have plenty of time for all the git juggling, and general time having it soak before imposing it on everyone.

dbyron-sf avatar Feb 17 '25 16:02 dbyron-sf

@dbyron-sf do you think we can restart this work?

christosarvanitis avatar Jun 11 '25 14:06 christosarvanitis

@dbyron-sf do you think we can restart this work?

Sure, if it happens in https://github.com/spinnaker/spinnaker. There are still a few other disruptive changes coming soon (the rest of the retrofit2 changes, new gate oauth, spring boot 3. Let's see which ones are ready to go first.

dbyron-sf avatar Jun 11 '25 16:06 dbyron-sf