kork icon indicating copy to clipboard operation
kork copied to clipboard

Bumped aws sdk version for FIPS compliance

Open cs-simental opened this issue 1 year ago • 10 comments

Version 1.12.399 is the lowest version that enables FIPS endpoints for GovCloud (US) regions in SDK

cs-simental avatar Apr 05 '23 15:04 cs-simental

The following commits need their title changed:

  • 9bb6e97651b65bbd09418733b62fedf9aa3a3cde: Bumped aws sdk version for FIPS compliance

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

spinnakerbot avatar Apr 05 '23 16:04 spinnakerbot

@dbyron-sf made a pull request for https://github.com/Netflix/awsobjectmapper

https://github.com/Netflix/awsobjectmapper/pull/116

do you know who I may reach to give a look to the request?

cs-simental avatar Apr 05 '23 16:04 cs-simental

Thanks. They're usually pretty prompt.

dbyron-sf avatar Apr 05 '23 16:04 dbyron-sf

@mergifyio update

dbyron-sf avatar Apr 17 '23 19:04 dbyron-sf

update

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request. @armory-io needs to authorize modification on its head branch. err-code: E3409

mergify[bot] avatar Apr 17 '23 19:04 mergify[bot]

@cs-simental could you rebase please? Also would be great if you can link to some docs showing 1.12.399 as the minimum version for govcloud fips compliance.

dbyron-sf avatar Apr 17 '23 19:04 dbyron-sf

@dbyron-sf rebased.

Link to FIPS documentation in aws-java-sdk: https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md#112399-2023-02-02

cs-simental avatar Apr 17 '23 22:04 cs-simental

Thanks @cs-simental . Can you also let us know where you've tested this please.

dbyron-sf avatar Apr 17 '23 22:04 dbyron-sf

Hello 👋 updating the sdk also helps with Configuring lambda SnapStart as it was introduced in 1.12.351

see issue: https://github.com/spinnaker-plugins/aws-lambda-deployment-plugin-spinnaker/issues/128

Avi1235 avatar Apr 20 '23 23:04 Avi1235

Hello 👋 updating the sdk also helps with Configuring lambda SnapStart as it was introduced in 1.12.351

see issue: spinnaker-plugins/aws-lambda-deployment-plugin-spinnaker#128

Thanks for highlighting this - we're working on moving the Lambda plugin into the main codebase and snapstart was on my list of things to add once that effort was done.

mattgogerly avatar May 11 '23 22:05 mattgogerly