clouddriver
clouddriver copied to clipboard
fix(google): Fix for the missing CredentialsRepository issue
This fix addresses the issue - https://github.com/spinnaker/spinnaker/issues/6733
@kirangodishala https://github.com/spinnaker/clouddriver/pull/5747 is the PR that introduced the bug, right?
Yes @dbyron-sf. And this PR is the fix for that.
@dbyron-sf - As this issue occurs only after all the configuration and beans are loaded, this can't be verified through a unit test. Will work on integration tests under buildtool repo. Could you please merge this PR so that the clouddriver would be usable.
@dbyron-sf - As this issue occurs only after all the configuration and beans are loaded, this can't be verified through a unit test. Will work on integration tests under buildtool repo. Could you please merge this PR so that the clouddriver would be usable.
I do think it's possible to test this using ApplicationContextRunner, like this or this.
As for timing, I'm hoping for a fix for one more issue before releasing 1.29.1. I won't let the absence of tests hold that up.
I do think it's possible to test this using ApplicationContextRunner, like this or this.
@dbyron-sf - Thanks for the suggestion. I have added the test. Could you please merge the PR?
Thanks much @kirangodishala !
@mergifyio backport release-1.29.x
backport release-1.29.x
✅ Backports have been created
-
#5799 fix(google): Fix for the missing CredentialsRepository issue (backport #5793) has been created for branch
release-1.29.x