clouddriver icon indicating copy to clipboard operation
clouddriver copied to clipboard

fix(google): Fix for the missing CredentialsRepository issue

Open kirangodishala opened this issue 2 years ago • 5 comments

This fix addresses the issue - https://github.com/spinnaker/spinnaker/issues/6733

kirangodishala avatar Oct 09 '22 18:10 kirangodishala

@kirangodishala https://github.com/spinnaker/clouddriver/pull/5747 is the PR that introduced the bug, right?

dbyron-sf avatar Oct 10 '22 18:10 dbyron-sf

Yes @dbyron-sf. And this PR is the fix for that.

kirangodishala avatar Oct 11 '22 01:10 kirangodishala

@dbyron-sf - As this issue occurs only after all the configuration and beans are loaded, this can't be verified through a unit test. Will work on integration tests under buildtool repo. Could you please merge this PR so that the clouddriver would be usable.

kirangodishala avatar Oct 12 '22 17:10 kirangodishala

@dbyron-sf - As this issue occurs only after all the configuration and beans are loaded, this can't be verified through a unit test. Will work on integration tests under buildtool repo. Could you please merge this PR so that the clouddriver would be usable.

I do think it's possible to test this using ApplicationContextRunner, like this or this.

dbyron-sf avatar Oct 12 '22 17:10 dbyron-sf

As for timing, I'm hoping for a fix for one more issue before releasing 1.29.1. I won't let the absence of tests hold that up.

dbyron-sf avatar Oct 12 '22 18:10 dbyron-sf

I do think it's possible to test this using ApplicationContextRunner, like this or this.

@dbyron-sf - Thanks for the suggestion. I have added the test. Could you please merge the PR?

kirangodishala avatar Oct 18 '22 15:10 kirangodishala

Thanks much @kirangodishala !

dbyron-sf avatar Oct 18 '22 16:10 dbyron-sf

@mergifyio backport release-1.29.x

dbyron-sf avatar Oct 18 '22 17:10 dbyron-sf

backport release-1.29.x

✅ Backports have been created

mergify[bot] avatar Oct 18 '22 17:10 mergify[bot]