spin-operator icon indicating copy to clipboard operation
spin-operator copied to clipboard
verified publisher icon spinkube

Add podServiceAccountName to SpinApp CRD

Open ThorstenHans opened this issue 1 year ago • 2 comments

With this PR, users are able to specify the ServiceAccountName for underlying pods

closes #226

ThorstenHans avatar May 06 '24 18:05 ThorstenHans

What does the failure scenario look like when a service account with the provided name doesn't exist?

@michelleN that's a good question. When a user tries to create a Pod and is referencing a non-existing ServiceAccountName, the Pod is not accepted at all and a corresponding error message is presented to the user.

I would prefer our controller also checking for the specified ServiceAccountName in the current namespace, before it starts with creating underlying Kubernetes primitives

ThorstenHans avatar May 15 '24 14:05 ThorstenHans

Any tips how I could implement validation of the serviceAccountName in the controller in order to prevent the SpinApp from being created, if the user provides a non-existing serviceAccountName?

ThorstenHans avatar Jun 11 '24 06:06 ThorstenHans