helpful_stan_functions icon indicating copy to clipboard operation
helpful_stan_functions copied to clipboard

fixed coupla_defination.stan of zero_constrain

Open yamikarajput546 opened this issue 3 years ago • 4 comments

Please check the PR and merge the changes

yamikarajput546 avatar Jan 29 '22 06:01 yamikarajput546

@yamikarajput546 thanks for these! Welcome and look forward to working with you

spinkney avatar Jan 29 '22 11:01 spinkney

i've update the changes but i don't know why again the conflicts ? @spinkney please review it

yamikarajput546 avatar Jan 29 '22 13:01 yamikarajput546

I merged the other pr tada! And I fixed the merge conflicts with this one.

For this one:

  • add those functions to separate .stanfunctions files and document
  • we need the doxygen comments at the top and a description of the math. Look at https://github.com/spinkney/helpful_stan_functions/blob/main/functions/copula/normal_copula.stanfunctions how to do the LaTeX and documentation.
  • rename the file correlation_angles_constrain_work.stan to just correlation_angles_constrain.stanfunctions

Thanks for that @spinkney i'll update as you mentioned like renamed and pushed the changes but as the workflow has failed so will try the doxygen comments

yamikarajput546 avatar Jan 30 '22 11:01 yamikarajput546

I merged the other pr tada! And I fixed the merge conflicts with this one. For this one:

  • add those functions to separate .stanfunctions files and document
  • we need the doxygen comments at the top and a description of the math. Look at https://github.com/spinkney/helpful_stan_functions/blob/main/functions/copula/normal_copula.stanfunctions how to do the LaTeX and documentation.
  • rename the file correlation_angles_constrain_work.stan to just correlation_angles_constrain.stanfunctions

Thanks for that @spinkney i'll update as you mentioned like renamed and pushed the changes but as the workflow has failed so will try the doxygen comments

Just tag me once you want a review. Thanks again!

spinkney avatar Feb 01 '22 11:02 spinkney