fix_microsoft_links icon indicating copy to clipboard operation
fix_microsoft_links copied to clipboard

Published 20 hours ago • verified publisher icon spilliton

Microsoft Office 2007 on Win XP

Open timdiggins opened this issue 11 years ago • 2 comments

I've discovered that Microsoft Office 2007 on Win XP (at least, one I've seen...) gives a user agent that seems to be identical to IE 7...

So in my fork I've made a test & fix for this (https://github.com/red56/fix_microsoft_links/commit/0bfc37d0137033e3a230e3dc2225475fc8282861), though it's likely to make IE7 present the blank page with meta-refrsh (does anyone care). Can create a pull request if you think this is generally useful.

timdiggins avatar Mar 10 '14 21:03 timdiggins

Interesting...so many different user agents!

Sounds reasonable, if anyone complains we can make this part configurable. Go ahead and make a PR if you want :)

spilliton avatar Mar 11 '14 16:03 spilliton

Actually, I've discovered that it was something was matching IE11 user agent, so I'm now a bit nervous of using this gem at all (have backed out from it). I think I'd rather check for unauthorized and THEN match (and possibly just display a login page at that point). More change, but much safer. Will report back if/when I find out the user agent for IE11

timdiggins avatar Mar 11 '14 17:03 timdiggins