Maximilian Köller

Results 36 comments of Maximilian Köller

@D4N14L / @octogonz are there any updates?

@octogonz would be really nice to have this merged. Can you please do a review here.

I think in that case you can also skip adding playwright tests. Since we anyway have to construct the event manually unit tests will do. But there is now one...

Just one more thing, my previous comment broke the code on Firefox. Seems like the desktop version does not support `ToucheEvent`, so please write the check like this: `const isMouse...

thx a lot. Your changes are looking good. We are currently facing CI issues, most likely due to github changing terms of use without informing us and we are now...

FYI, we are still having the LFS issues. Github support should be on it, but so far they were not able to fix anything.

Seems like there are still conflicts and also a format issue. Ideally you do not merge master-origin into your branch but rebase onto our master. That should solve the issue.

@ColinFrick yes, we are also planning to do this later this year. Right now the focus is on improving types and solving the most broken parts.. Once this is done,...

Thx a lot for the detailed description. Your supposed fix sounds reasonable. Can provide a PR?

Finally had time to investigate here a little longer. It seems like we are having a potential conflict around `pageSize`: When using the pager in this scenario, we would like...