spire icon indicating copy to clipboard operation
spire copied to clipboard

Consider using gRPC metrics from go-grpc-middleware

Open AlexZzz opened this issue 1 year ago • 2 comments

  • Version: 1.9.5
  • Platform: any
  • Subsystem: server and agnet

Hi! There're standard prometheus metrics that are exposed by grpc-go-middleware. Using it prevents teams from creating hundreds of dashboards about gRPC communication.

It would be nice to see these metrics in spire.

AlexZzz avatar Jul 17 '24 10:07 AlexZzz

Thanks for opening this @AlexZzz

As part of this work, we should take a look at what overlap there is (if any) with existing SPIRE metrics. We should probably prefer metrics coming from this package over our own when/where possible.

evan2645 avatar Jul 18 '24 19:07 evan2645

This issue is stale because it has been open for 365 days with no activity.

github-actions[bot] avatar Jul 18 '25 22:07 github-actions[bot]