spire icon indicating copy to clipboard operation
spire copied to clipboard

Remove deprecated ttl flag

Open azdagron opened this issue 1 year ago • 1 comments

The CLI has long since deprecated the -ttl flag in favor of the SVID specific flags -x509SVIDTTL and -jwtSVIDTTL. The deprecated flag should be removed.

azdagron avatar Jun 25 '24 19:06 azdagron

@azdagron I want to work on this issue, can you explain it more?

ayushrakesh avatar Jun 28 '24 07:06 ayushrakesh

@ayushrakesh see https://github.com/spiffe/spire/blob/main/cmd/spire-server/cli/entry/create.go#L51 , https://github.com/spiffe/spire/blob/main/cmd/spire-server/cli/entry/update.go#L48

	// TTL for x509 and JWT SVIDs issued to this workload, unless type specific TTLs are set.
	// This field is deprecated in favor of the x509SVIDTTL and jwtSVIDTTL fields and will be
	// removed in a future release.

we want to remove ttl flag entirely in favor of the credential primitive-specific x509 / jwt flags. Probably spire-server.md also needs updating on this removal.

amoore877 avatar Aug 19 '24 19:08 amoore877

I'm working on this issue.

heymarcel avatar Sep 09 '24 20:09 heymarcel

I've opened a PR: https://github.com/spiffe/spire/pull/5483

heymarcel avatar Sep 09 '24 21:09 heymarcel

Resolved by #5483.

azdagron avatar Sep 24 '24 18:09 azdagron