spiffe.io
spiffe.io copied to clipboard
spiffe
Consolidating a few past PRs
Description of the change Fixing broken URLs that were fixed in other open PRs (listed below) and also removed references to Node Resolver (PR #262 ).
Which issue this PR fixes
- PR #240
- PR #231
- ~PR #285~
- PR #262 fixes GH Issue #263
Deploy Preview for spiffe ready!
| Name | Link |
|---|---|
| Latest commit | f7df7db2819b746f3043bfd8770675b0a490b228 |
| Latest deploy log | https://app.netlify.com/sites/spiffe/deploys/663e2037a6fc7100072ea65f |
| Deploy Preview | https://deploy-preview-302--spiffe.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
For the server diagram, a couple things:
- draw.io became diagrams.net
- When you upload the new server.drawio file to diagrams.net it is still the source image, so you can edit and export it
Hello! I saw that main was pulled into the branch and wanted to break out (for ease of reading) what needs to be resolved on the PR so it can be merged :)
I sync’d up with @quintessence last week on this, made a suggestion which I think has been accepted. Also, just to remove the conversation around DCO and attribution, we backed out the commit related to https://github.com/spiffe/spiffe.io/pull/285 ... also had a look at https://github.com/spiffe/spiffe.io/pull/262 which included some changes now found in this PR, but those changes were limited to focused deletions etc .. I thought it’s probably fine to include, but let me know if you prefer to cherry pick there as well
It looks like commit 7879fb7 has a failed DCO, even though the signature is there and is also on prior commits. Is there a way to re-trigger the DCO check? A bot command to run or similar?
I'm wondering if it's reading the "fail" from 37c2460 as a DCO failure - but it wasn't, the Deploy Preview failed there for some reason.
@quintessence thanks for fixing the commit history :) this looks good to me, it just needs to be updated with the latest changes from master and that should be it. @sanderson042 do you have any pending comment?
