spiffe.io
spiffe.io copied to clipboard
Patches to pin to a specific python version
Avoids the following error when running make docker-serve
by pinning python to a specific version
=> ERROR [ 9/14] RUN pyenv install 1.9s
------
> [ 9/14] RUN pyenv install:
#13 1.593 python-build: definition not found: 3.8
Signed-off-by: Andrew Jessup [email protected]
@mchurichi Would love your review on this if possible please
Deploy Preview for spiffe ready!
Name | Link |
---|---|
Latest commit | f0b64a5e5e5af29e84b3e5fb45b6ee847d097517 |
Latest deploy log | https://app.netlify.com/sites/spiffe/deploys/65c3d923af02ce0007d4a943 |
Deploy Preview | https://deploy-preview-248--spiffe.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
The CI errors are a bit confusing considering the netlify bot was still able to make a site preview
The first build for this PR failed because of #250. Subsequent builds have succeeded, but for some reason Github checks aren't picking them up.
Anyways, I think we need some research before merging this, as we already found an issue with pinning to an exact/patch version as stated in #239.
@ajessup maybe if you re-push this PR it will trigger CI to update?
looks like CI is fixed now after the re-push :)
@sanderson042 @evan2645 @mchurichi @Andres-GC @umairmkhan this is ready for approval and merge
Anyways, I think we need some research before merging this, as we already found an issue with pinning to an exact/patch version as stated in https://github.com/spiffe/spiffe.io/pull/239.
has this researching been completed?
are we able to merge this? is it still valid?