spiffe-helper icon indicating copy to clipboard operation
spiffe-helper copied to clipboard

Add configuration to exit after retrieving JWTs (closes #121)

Open keeganwitt opened this issue 1 year ago • 3 comments

keeganwitt avatar Jan 18 '24 06:01 keeganwitt

Why two flags? There ever going to be a case where both jwt and x509 are enabled at the same time? If so, it probably should wait for both? If two flags, it may be confusing in that case.

kfox1111 avatar Jan 18 '24 11:01 kfox1111

Im planning to do a small refactor to create a daemon mode flag. when disabled will just download the x509 and/or JWTs and then exit. That should cover this with only a single flag.

faisal-memon avatar Jan 18 '24 21:01 faisal-memon

Why two flags? There ever going to be a case where both jwt and x509 are enabled at the same time? If so, it probably should wait for both? If two flags, it may be confusing in that case.

Yes, I was thinking some use cases might require both. Ideally, yes, it would wait for both. But I wasn't sure how to implement that, particularly since there might be multiple JWTs. If someone can guide me with an idea, I'll give it a shot.

keeganwitt avatar Jan 18 '24 22:01 keeganwitt

@keeganwitt Finally got around to creating the PR i mentioned above with a single daemon_mode flag. Please take a look and lmk if its ok to close this PR. https://github.com/spiffe/spiffe-helper/pull/161

faisal-memon avatar May 21 '24 22:05 faisal-memon

Conceptually, yea, think that will solve what I was trying to do here.

keeganwitt avatar May 22 '24 19:05 keeganwitt