spiffe-helper icon indicating copy to clipboard operation
spiffe-helper copied to clipboard

Add ability to exit on successful retrieval of JWT SVID

Open keeganwitt opened this issue 1 year ago • 5 comments

keeganwitt avatar Dec 20 '23 22:12 keeganwitt

It also can not run a command on exit near as I can tell. The code should probably call the same function that does cmd execution and signaling as well as exit?

kfox1111 avatar Jan 10 '24 16:01 kfox1111

It also can not run a command on exit near as I can tell. The code should probably call the same function that does cmd execution and signaling as well as exit?

Yes, I think so. It's confusing that there's not parity here.

keeganwitt avatar Jan 11 '24 03:01 keeganwitt

Actually signaling might be confusing since if there's multiple JWTs, it would signal multiple times.

keeganwitt avatar Jan 18 '24 03:01 keeganwitt

Actually signaling might be confusing since if there's multiple JWTs, it would signal multiple times.

The same is true on exiting? With multiple jwts I'd think the exit should happen when all have been fetched. Probably signaling, and cmd should happen the same way? But that is more tricky...

kfox1111 avatar Jan 18 '24 11:01 kfox1111

The same is true on exiting? With multiple jwts I'd think the exit should happen when all have been fetched. Probably signaling, and cmd should happen the same way? But that is more tricky...

Yea, I guess it should signal once when all the JWTs are fetched, not each time. Dunno why I didn't think of that.

keeganwitt avatar Jan 19 '24 01:01 keeganwitt