java-spiffe icon indicating copy to clipboard operation
java-spiffe copied to clipboard

DefaultX509Source should have the ability to set up more options on WorkloadApiClient

Open alwaysastudent opened this issue 4 years ago • 2 comments

Currently we can configure, spiffeSocketPath over io.spiffe.workloadapi.DefaultX509Source.X509SourceOptions.

But there are more configuration options available on io.spiffe.workloadapi.DefaultWorkloadApiClient.ClientOptions which we would like to customize while creating a new X509 source. Is it possible to make ClientOptions be configurable from X509SourceOptions as well?

Also would be great if retryExecutor can also be made customizable?

Sometimes we would like to run these as daemon threads instead.

alwaysastudent avatar Aug 12 '21 05:08 alwaysastudent

It makes sense to me.

@alwaysastudent, would you be willing to submit a PR ?

maxlambrecht avatar Aug 12 '21 10:08 maxlambrecht

Sure, thank you. I can submit a PR for this.

alwaysastudent avatar Aug 12 '21 14:08 alwaysastudent