rules_conda icon indicating copy to clipboard operation
rules_conda copied to clipboard

Add GitHub Action for linting

Open GabrielDougherty opened this issue 3 years ago • 2 comments

It would be nice to have a GitHub Action set up for code autoformatting. Maybe we could use the existing Buildifier GitHub Action: https://github.com/thompsonja/bazel-buildifier

GabrielDougherty avatar Nov 09 '21 22:11 GabrielDougherty

I'm always reluctant to enforce automatic formatting because no formatter is perfect and there might be other issues with commit authorship or permission to commit on forks (more points here).

Another option would be just linting. So the action would run a static analysis of code (including logical errors or simply formatting) on each pull request and fail if something is wrong. Then the PR author would need to resolve the errors and format code manually.

What do you think about that?

spietras avatar Nov 11 '21 18:11 spietras

Sure, that is fine with me. Let's do linting.

GabrielDougherty avatar Nov 11 '21 22:11 GabrielDougherty