Sami Pietikäinen

Results 15 comments of Sami Pietikäinen

This is something I don't have a very strong opinion about. I've seen both used, and I don't think it is obvious which one is idiomatic. Though, if you have...

Hyper supports rustls so it should not be a big effort to add the support here, and I think such option parameter would make sense. For now, it should already...

I have not tried this case, but I think it should be possible by using the Builder and providing your own HyperClient that is configured to disable cert verification. Probably...

Very good! I'm travelling this week so I will look at this and the other PR during the weekend.

Overall the PR looks good, but there is one thing I would change. Now `impl From for RestClient` can panic. Even though it is probably very unlikely that building the...

You are totally right. I overlooked the fact that, even though it is not as explicitly visible, of course `#[tokio::main]` has to create the runtime as well. But as said,...

Thanks for sending the contribution! Would you be able to provide an example how you are creating the client after these changes? I ran the tests, but most of them...

I do like the approach taken here, and it works *almost* perfectly. As you mentioned, `new` and `new_blocking` now work as expected without additional type annotations. However, when using the...

I actually just noticed a regression. For some reason HTTPS requests with blocking clients do not work (`cargo test get`): ``` thread 'basic_get_https' panicked at 'called `Result::unwrap()` on an `Err`...