spiderpool icon indicating copy to clipboard operation
spiderpool copied to clipboard

fix: ipv6 address validity issue

Open ty-ci-robot opened this issue 2 years ago • 3 comments

What this PR does / why we need it:

  • Fix: When the ipv6 address is fd00:015d::1, but in the pod it is fd00:15d::1,
  • in this case, using "ip -6 r | grep 'default via fd00:015d::1'" does not retrieve the content, so os/exec will return an error when executed

Which issue(s) this PR fixes: #860 #850

Special notes for your reviewer:

make sure your commit is signed off

ty-ci-robot avatar Oct 17 '22 08:10 ty-ci-robot

Codecov Report

Merging #893 (37cc945) into main (31de7ee) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #893   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files           8        8           
  Lines         592      592           
=======================================
  Hits          484      484           
  Misses         89       89           
  Partials       19       19           
Flag Coverage Δ
unittests 81.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Oct 17 '22 08:10 codecov[bot]

这个 方案不能解决根本问题 ipv6 地址 有很多场景 都会导致 简写 该问题的本质 应该是 把 设置 和 生效值 都 取出后,进行 ipv6 全写展开后,进行 比较

weizhoublue avatar Oct 17 '22 11:10 weizhoublue

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 19 '22 01:10 sonarqubecloud[bot]