marketplace icon indicating copy to clipboard operation
marketplace copied to clipboard

Validated Versions Checkmark

Open afonsojramos opened this issue 1 year ago • 6 comments

📝 Provide a description of the new feature

Add two checkmarks for each theme, extension, and custom app to "officially" validate that the latest version of Spotify / Spicetify is supported by it.

image

This would work by adding two fields in each of the manifests. If people wanted to get the checks on their extensions then they need to update these values with the latest. This way forces a community-led effort of better detailing/finding when/what is not working in new versions.

image

➕ Additional Information

This feature is dependent on the working mono-manifest implementation.

afonsojramos avatar Jul 05 '22 23:07 afonsojramos

Wouldn't it be better to make the values a range? I.E "2.9.9-2.10.0" Then we just split at the hyphen

CharlieS1103 avatar Jul 06 '22 00:07 CharlieS1103

Could be as well, yes, however, I'm not sure which one I prefer... In theory, we should always focus on the latest of everything as we've discussed again and again. Especially because you are talking about two different things. That is, it says that supports 2.9.9 and 1.1.88, but does it support 2.10.0 and 1.1.88? Or just 2.10.0 and 1.1.89? For this reason, I'd prefer to only guarantee the latest "pairing".

afonsojramos avatar Jul 06 '22 00:07 afonsojramos

@afonsojramos That's certainly a good point, one artifact of this though might be that it will allow us to let users on older versions of spicetify download older versions of extensions and themes(if we can somehow link the latest verified functional state in the manifest to the respective commit in the repository. )

CharlieS1103 avatar Jul 06 '22 04:07 CharlieS1103

Thinking in my head, that seems very complicated to do (fixing certain commit hashes, etc.), but it can be something to support in the future indeed.

afonsojramos avatar Jul 06 '22 09:07 afonsojramos

@afonsojramos Yeah, we'd have to add an array of commit id's in themes and extensions manifests and allow users to select which commit to use is probs that way I would do it. Handling it automatically would just lead to more errors imo

CharlieS1103 avatar Jul 06 '22 18:07 CharlieS1103

@CharlieS1103 that sounds good actually, but let's move that discussion to later. Once we close this issue we can touch again on this.

afonsojramos avatar Jul 06 '22 20:07 afonsojramos