cli icon indicating copy to clipboard operation
cli copied to clipboard

[FullApp Display] Like button

Open makew0rld opened this issue 2 years ago • 8 comments

📝 Provide a description of the new feature

It would be nice to have the option to display the like (heart) button for songs when in Full App Display. That way I can easily like songs that catch my ear without having to exit the display and find the button.

Thanks! I'm enjoying spicetify and this extension :)

➕ Additional Information

No response

makew0rld avatar Jul 25 '22 23:07 makew0rld

Just for more context to whoever wants to work on this, where would you want to place this button? Supposedly the Like button would go to the right of the seekbar on normal view but then lies the problem for Vertical mode where everything this perfectly centered:

image

kyrie25 avatar Jul 26 '22 08:07 kyrie25

Here's two options.

Beside the song title:

image

The title and heart could be centred together, to keep everything centred. But I don't think it looks too bad not centred as well!

Or it could go beside the title and artist together:

image

Once again this could be centred, with the title and artist on the left and the heart on the right.

makew0rld avatar Jul 26 '22 14:07 makew0rld

If you're running the latest version of Full App Display, the like button in shown when you enable Enable Extra Controls

fallsimply avatar Jul 26 '22 19:07 fallsimply

I see. I'm stuck on spicetify 2.9.9 because I'm on Linux. Would be nice to get a spicetify update that still supports the older Linux Spotify, but I was told it's not possible.

Will close the issue now, thanks for explaining.

makew0rld avatar Jul 26 '22 20:07 makew0rld

I see. I'm stuck on spicetify 2.9.9 because I'm on Linux. Would be nice to get a spicetify update that still supports the older Linux Spotify, but I was told it's not possible.

Will close the issue now, thanks for explaining.

You can download master zip, find this extension inside extensions folder and replace it inside spicetify-cli bin folder.

rxri avatar Jul 26 '22 20:07 rxri

If you're running the latest version of Full App Display, the like button in shown when you enable Enable Extra Controls

@fallsimply seems like this is false actually, or it relies on a spicetify version later than 2.9.9. I am running the latest version of fullAppDisplay.js.

Proof:

~
➤ sha256sum ~/.spicetify/Extensions/fullAppDisplay.js 
d2c31d22983eccebd9b4d2935ed647338fa4bbcb4080a0b422e40d18598c267a  /home/makeworld/.spicetify/Extensions/fullAppDisplay.js

~
➤ curl -sSL https://github.com/spicetify/spicetify-cli/raw/master/Extensions/fullAppDisplay.js | sha256sum
d2c31d22983eccebd9b4d2935ed647338fa4bbcb4080a0b422e40d18598c267a  -

~
➤ spicetify --version
2.9.9

I have no option available to me called "Enable Extra Controls". In fact if you look at the latest source code, that option doesn't even exist:

https://github.com/spicetify/spicetify-cli/blob/396d701adc915a853e0a94e3fa4a34293d9d3933/Extensions/fullAppDisplay.js#L754-L764

Not sure why you wrote your comment then, maybe you're using some fork of the extension or something?

makew0rld avatar Jul 27 '22 16:07 makew0rld

Spicetify Marketplace was using a modified version. Here's the link https://github.com/huhridge/huh-spicetify-extensions#full-app-display-modified

fallsimply avatar Jul 27 '22 16:07 fallsimply

Oh ok, thanks for explaining. I will leave this issue open because I'd still like to have a like button for the built-in Full App Display extension.

makew0rld avatar Jul 27 '22 16:07 makew0rld