Sebastiaan Huber

Results 605 comments of Sebastiaan Huber

> Sure, the hook approach would work. 👍 For this PR, maybe we can just call the `create_merged_output` step first, so the `output_parameters` are already set before the `results`? Does...

> This seems to just import the parser class, no? Can't we just remove this fixture and directly load the parser class? One would think yeah :sweat_smile: Saves an explicit...

> @sphuber any chance we can push for a v2.1 soonish? I am trying my hardest. Almost everything is there. Just waiting for a final release of `plumpy` and `kiwipy`,...

@mbercx `aiida-core==2.1` is out

> @sphuber any idea why the integration CI test is now failing to install the SSSP? thinking It's because the CLI is broken with `aiida-core==2.1`, see this issue: https://github.com/aiidateam/aiida-pseudo/issues/130 I...

Ok, `aiida-pseudo==0.8.0` is released and I updated `main` branch to add the dependency requirement. You can rebase now and tests should run without problems.

I had mentioned this to them early this year https://github.com/materialsproject/pymatgen/issues/2332 They closed it but I never checked if they actually fixed it. They may have done in a new release...

Hi @lbotsch , thanks for the report. I have not implemented this calculation job so I am not sure what the reasoning behind that choice was. Looking at the history...

Think you may have accidentally changed the permissions on all the files. Please revert that. Let me know if you don't know how and I can help out

Try the following from your repo: ``` git checkout bastonero/phonons-wc git fetch --all git reset --soft master chmod 644 setup.json aiida_common_workflows/workflows/phonons/common_force_sets.py tests/workflows/phonons/test_workchain_force_sets.py git add setup.json aiida_common_workflows/workflows/phonons/common_force_sets.py tests/workflows/phonons/test_workchain_force_sets.py git stash --keep-index...