sphinxcontrib-django icon indicating copy to clipboard operation
sphinxcontrib-django copied to clipboard

GitHub Actions: Upgrade to codecov v4

Open cclauss opened this issue 11 months ago • 5 comments

Short description

GitHub Actions: Upgrade to codecov v4

Proposed changes

  • https://github.com/codecov/codecov-action?tab=readme-ov-file#example-workflowyml-with-codecov-action

Resolved issues

Fixes: #69

cclauss avatar Mar 04 '24 18:03 cclauss

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.64%. Comparing base (e9d4308) to head (8339a13).

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #70      +/-   ##
===========================================
- Coverage   100.00%   99.64%   -0.36%     
===========================================
  Files           10       20      +10     
  Lines          328      559     +231     
===========================================
+ Hits           328      557     +229     
- Misses           0        2       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 04 '24 21:03 codecov[bot]

Snap!

cclauss avatar Mar 04 '24 21:03 cclauss

setup.py usually goes untested and more and more it is just getting removed.

  • https://setuptools.pypa.io/en/latest/deprecated/commands.html

cclauss avatar Mar 04 '24 22:03 cclauss

setup.py usually goes untested and more and more it is just getting removed.

* https://setuptools.pypa.io/en/latest/deprecated/commands.html

Right, I'm also fine with removing it. :+1: It should have no downsides for users installing this package via pip, right?

timobrembeck avatar Mar 04 '24 22:03 timobrembeck

Let's not lose setup.py in this pull request. I doubt the loss of one-third of 1% is caused by the presence of setup.py. Once this PR is merged then 99.64% will be the coverage's new normal (green). See section 06 of https://about.codecov.io/resource/what-is-code-coverage on why 100% coverage is not vital.

cclauss avatar Mar 04 '24 22:03 cclauss