sphinx icon indicating copy to clipboard operation
sphinx copied to clipboard

Fix rendering of enumerations inheriting from mixin and data types.

Open picnixz opened this issue 1 year ago • 1 comments

Fix #11353.

I'm not sure that everything is covered so feel free to argue.

picnixz avatar Aug 15 '23 10:08 picnixz

@alxroyer Could you check if this patch would fix your issue?

picnixz avatar Feb 25 '24 14:02 picnixz

Thanks to the new tests, I observed that there were issues. So it's still WIP

picnixz avatar Mar 18 '24 17:03 picnixz

Thanks to the new tests, I observed that there were issues. So it's still WIP

Maybe convert to draft then 😄 ?

chrisjsewell avatar Mar 19 '24 10:03 chrisjsewell

Maybe convert to draft then 😄 ?

I fixed it actually, now I'm just cleaning it up.

picnixz avatar Mar 19 '24 10:03 picnixz

So there is something with docutils but I don't know what.

@jayaddison can you investigate this one please?

picnixz avatar Mar 19 '24 10:03 picnixz

There's definitely something wrong with docutils HEAD. Maybe it's my fix that is causing the issue because it's really weird.

picnixz avatar Mar 19 '24 15:03 picnixz

There's definitely something wrong with docutils HEAD. Maybe it's my fix that is causing the issue because it's really weird.

Lokks like tests/test_builders/test_build_linkcheck.py::test_defaults is flaky, because I had the same failure on my PR (just re-run and it dissapeared)

chrisjsewell avatar Mar 19 '24 15:03 chrisjsewell

Lokks like tests/test_builders/test_build_linkcheck.py::test_defaults is flaky, because I had the same failure on my PR (just re-run and it dissapeared)

It's funny because every time I rerun the test, it failed. So I am quite unlucky :(

picnixz avatar Mar 19 '24 15:03 picnixz

I am really unlucky. I clearly don't know why this one became flaky now...

picnixz avatar Mar 19 '24 16:03 picnixz