alabaster icon indicating copy to clipboard operation
alabaster copied to clipboard

support arbitrary source URLs, closes #87

Open anarcat opened this issue 7 years ago • 8 comments

anarcat avatar Sep 05 '16 03:09 anarcat

... ping?

anarcat avatar Nov 16 '17 18:11 anarcat

added docs and changelog entries for this - anything missing?

anarcat avatar Nov 16 '17 18:11 anarcat

Needs to be rebased.

abitrolly avatar Jan 07 '19 20:01 abitrolly

Needs to be rebased.

What are the odds of this being merged if I go through that effort? That PR has been idle for two years without feedback so I'm hesitant in working anymore on it.

anarcat avatar Jan 08 '19 20:01 anarcat

I think odds are low. Thanking @bitprophet and asking how things are on the other side of the world might help to understand if he has time for the review. Otherwise it is just a good git practice.

image

You may be interested to know how to add arbitrary source URLs without patching this theme.

https://github.com/release-monitoring/anitya/pull/693/commits/84c7812ff600b8d86d048e18986fd3f8cce09a29#diff-cac3dc3bfd42bc240bc9eb924f8dbfdd

abitrolly avatar Jan 08 '19 21:01 abitrolly

Made it into separate snippet and preserved your parameter name https://gist.github.com/abitrolly/12522b399c92606d7b09e9342c3f788b

abitrolly avatar Jan 08 '19 21:01 abitrolly

i resolved the merge conflict at least now...

anarcat avatar Jan 10 '19 01:01 anarcat

You can try to rebase that instead.

abitrolly avatar Jan 11 '19 03:01 abitrolly