confluencebuilder
confluencebuilder copied to clipboard
sphinx-contrib
Allowing multiple pages with the same title
Adding an option to confluence_publish_postfix for making it dynamic and thus allowing users to be able to publish pages with the same titles in sub directories
Resolved ticket: #676
@jdknight Thanks for looking at the ticket and giving the concept your thoughts. Totally good ideas on how to actually calculate the hash. Since the key piece is that it has to be the same regardless of who runs it.
I am going to open this PR to show how I originally have it working on our system. That whole confluence_title_hash_root_path PR that i closed was.a total mess and never meant to open a PR with it. This way is so much cleaner since i just expand on your usage of postfix
But again I am open to all of your suggestions for changing this if there is a possibility of getting this feature into the base repos.
In addition, I forgot to mention that the original commit was not signed with a DCO. I would recommend reading how to address this, since it is a requirement for changes to be pulled into this extension.
Note that there may be a possibility of shipping out a v1.9 release of this extension next weekend (2022-07-[30-31]). If this is a feature you would like in the upcoming release, please let me know and we can try to ensure we can review/fix things up to get this merged in. Note that it is important that the changes are rebased with the DCO set, or I can neither merge this in or try to cleanup any of the proposed changes (if you wanted to have a maintainer finish the work). Otherwise, we can wait for the next following release to try to get this feature in.
Note that there may be a possibility of shipping out a v1.9 release of this extension next weekend (2022-07-[30-31]). If this is a feature you would like in the upcoming release, please let me know and we can try to ensure we can review/fix things up to get this merged in. Note that it is important that the changes are rebased with the DCO set, or I can neither merge this in or try to cleanup any of the proposed changes (if you wanted to have a maintainer finish the work). Otherwise, we can wait for the next following release to try to get this feature in.
Sorry was on vacation. I wasn't able to find the time to make the changes yet, going to try to spend some time this week on them. All your suggestions are spot on, I just need to find the time to do it. No rush on getting this into the next release, but I will make sure I have all this done by next week some time so I can get it onto the following release.
I changed the unit testing and methods a bit to make it easier for others to add additional placeholders. Great comments on making this more robust.