waterwheel icon indicating copy to clipboard operation
waterwheel copied to clipboard

add nix support

Open GTrunSec opened this issue 2 years ago • 6 comments

  • [X] packages
  • [X] Modules
    • [X] server
    • [X] client

GTrunSec avatar Apr 01 '22 09:04 GTrunSec

Hi @GTrunSec , thanks for the contribution.

I have to admit I have no experience with nix so I'm not really able to provide a proper review. Also, I noticed you're using sed in a few places (to ensure a reproducible build I think?). Feel free to make changes in the code itself to make this easier - the way version info gets embedded is a hack and if there is a better way I'm happy to switch.

sphenlee avatar Apr 12 '22 07:04 sphenlee

Adding the environment variable of git_hash can be easily solved.

GTrunSec avatar Apr 19 '22 20:04 GTrunSec

@blaggacao you can find the example of the config files here https://github.com/sphenlee/waterwheel/blob/main/sample/jobs/complex-dag.yml

At present, I am exploring nix-driver related things. I think the diagram based on petrinets is enough for use. Maybe we can examine the way for funflow in the future. For std flow expectation, I'd instead put them in the backend than wait in a tty for an indeterminate amount of time. Whether it's a c4 model or a jobs dag, it's sufficiently to analyze the data by json.

  • Regrading https://github.com/divnix/std/issues/49, Maybe we just need to add a watcher for flow in justfile.
  • std workflow, waterwheel would help us to achieve this motivation.

GTrunSec avatar Apr 20 '22 00:04 GTrunSec

@sphenlee Do you know about funflow? you might be interested in this project. I would like to add a notebook for the waterwheel to research the seeable and logical structure of the job, even DC field.

GTrunSec avatar Apr 20 '22 03:04 GTrunSec

this looks awsome.

blaggacao avatar Apr 20 '22 21:04 blaggacao

The nix PR works well for now. @sphenlee. Next, I'm going to talk about other features which need to be implemented.

GTrunSec avatar Apr 29 '22 01:04 GTrunSec