pflag icon indicating copy to clipboard operation
pflag copied to clipboard

Fix usage showing zero defaults for custom Value type

Open twelvelabs opened this issue 2 years ago • 2 comments

The defaultIsZeroValue() method was erroneously assuming that all types that implement IsBoolFlag() were bools - regardless of the return value of IsBoolFlag().

Fixes #360

twelvelabs avatar Sep 22 '22 21:09 twelvelabs

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 22 '22 21:09 CLAassistant

Not sure who the current maintainers are, so pinging recent last few folks who've approved/merged PRs 😬.

@therealmitchconnors, @eparis, @spf13 - would anyone mind taking a look?

twelvelabs avatar Oct 03 '22 16:10 twelvelabs