pflag icon indicating copy to clipboard operation
pflag copied to clipboard
verified publisher icon spf13

Switching from whitelist to Allowlist terminology

Open dubrie opened this issue 5 years ago • 7 comments

dubrie avatar Jun 02 '20 20:06 dubrie

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 02 '20 20:06 CLAassistant

The tests are failing because they no longer match func names; can you update them?

mckern avatar Jun 10 '20 10:06 mckern

@mckern weird, the test files don't look like they show up through the code search. Should be fixed now!

dubrie avatar Jun 10 '20 15:06 dubrie

Any chance to get this trivial PR to get merged?

rhuss avatar Jun 06 '21 15:06 rhuss

Is this still something you consider merging at some point in time ? If there are some concerns with backward compatibility I would be happy to re-add the old fields and deprecate those.

We are kind of waiting for this PR in https://github.com/knative/client/issues/1031

rhuss avatar Jan 04 '22 14:01 rhuss

Pinging @therealmitchconnors or @eparis who have merged recent PRs here and should have proper write access

dubrie avatar Jan 04 '22 17:01 dubrie

When this will be merged? We are waiting in kubebuilder to get this merged. If there is something which needs change. I am ready to work on that. Let me know. Thank you. cc: @dubrie @rhuss @mckern

Sajiyah-Salat avatar May 22 '23 01:05 Sajiyah-Salat