pflag icon indicating copy to clipboard operation
pflag copied to clipboard

make Value implementations public

Open DenKoren opened this issue 5 years ago • 1 comments

this makes possible to do the following:

flag := pflag.Flag{
	Name:      "sample-option",
	Shorthand: "s",
	DefValue:  "default value",
	Value:     pflag.NewStringValue("default value", new(string)),
	Usage:     "option you can add to cobra command with Flags().AddFlag()",
}

cobra.Command{}.Flags().AddFlag(&flag)

It allows one to keep the flag definition separately and use the same flag in several CLI commands or subcommands.

cobra has AddFlag() method, but, as far as I see, user can't just make Flag structure and use it. The thing that causes problems is Value field: it requites Value interface implementation, but you can't access default implementations available inside pflag. When Value field is nil, you face 'nil pointer dereference' error.

DenKoren avatar Oct 24 '19 13:10 DenKoren

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Korenevskiy Denis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 24 '19 13:10 CLAassistant